Hi, I took the liberty of ping'ing Sam on IRC a few minutes ago on your behalf (he is the original author of the three backports you did). He just got back from India, I could not miss the opportunity ;-) Cheers On 27/04/2015 10:05, Loic Dachary wrote: > Hi, > > I saw this morning the firefly integration branch passed rados and rbd suites :-) > > http://tracker.ceph.com/issues/11090#rados > http://tracker.ceph.com/issues/11090#rbd > > The issue has been updated accordingly. It means the following pull requests passed: > > $ git log --merges --oneline 12143ff9b25fdd96f8d1a9cecb1329c7f354d414..b91bbb434e6363a99a632cf3841f70f1f2549f79 > b91bbb4 Merge 4245: librbd: snap_remove should ignore -ENOENT errors > 6245bed Merge 4206: librbd: acquire cache_lock before refreshing parent > ef08aa9 Merge 4185: FAILED assert(soid < scrubber.start || soid >= scrubber.end) > ae1b18a Merge 3963: Rados.shutdown() dies with Illegal instruction (core dumped) > 056db0f Merge 4385: osd: ENOENT on clone > e4b1fd1 Merge 4384: pg stuck stale after create with activation delay > 597124b Merge 4383: erasure-code-profile set races with erasure-code-profile rm > b7bbd43 Merge 4382: osd/PGLog.h: 279: FAILED assert(log.log.size() == log_keys_debug.size()) > > Ouf ot these, three are backports ready to be reviewed by their original authors: > > 056db0f Merge 4385: osd: ENOENT on clone https://github.com/ceph/ceph/pull/4385 > e4b1fd1 Merge 4384: pg stuck stale after create with activation delay https://github.com/ceph/ceph/pull/4384 > b7bbd43 Merge 4382: osd/PGLog.h: 279: FAILED assert(log.log.size() == log_keys_debug.size()) > > The simplest way would be to ask for their review with a comment in the pull request, with a reference to the test suite results so they know it passed the suites. Will you have time to do this today ? If you don't have time, just let me know and I'll do it for you. > > Cheers > -- Loïc Dachary, Artisan Logiciel Libre
Attachment:
signature.asc
Description: OpenPGP digital signature
