1) The part where you add the operator<< and change the debug output looks good. 2) The other part looks like it should be an assert? Or it should complain to the central log so that it causes the test to fail at least? 1 and 2 should be separate commits. -Sam On Fri, Jan 16, 2015 at 8:39 AM, Loic Dachary <loic@xxxxxxxxxxx> wrote: > Hi Sam, > > In the context of http://tracker.ceph.com/issues/10524 FAILED assert(peer_missing.count(fromshard)) I propose to add some information for when it happens: > > https://github.com/ceph/ceph/pull/3389 > > If what happens really is that a bad peer ends up being added with in missing_loc.add_location, that will be a useful information. I tried a number of scenarios and could not find the right conditions to reproduce the problem locally. Hopefully this additional information will show me where to go :-) > > Cheers > > -- > Loïc Dachary, Artisan Logiciel Libre > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
