On Wed, Nov 5, 2014 at 8:49 PM, Alex Elder <elder@xxxxxxxx> wrote: > On 11/05/2014 11:33 AM, Ilya Dryomov wrote: >> Hello, >> >> These are fixes for the problem I found while trying to reproduce >> recently reopened http://tracker.ceph.com/issues/5429. I'm pretty sure >> this is what was reported in http://tracker.ceph.com/issues/8568 too. >> The exact BUG_ON() it points to is no longer there, but I checked with >> an older kernel and the reproducer I have for this triggered it. >> >> Thanks, >> >> Ilya > > All three of these look good to me. The interactions with > these lists has always been a bit too tricky; you've done a > lot to make sense of them. > > And I'm sure there are other BUG_ON() (or rbd_assert()) calls > that can be tamed--either removed, changed to warnings, or > changed to simply return errors where possible. > > Reviewed-by: Alex Elder <elder@xxxxxxxxxx> Thanks for the review, Alex! Ilya -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html