On Mon, 27 Jan 2014, Ilya Dryomov wrote: > On Mon, Jan 27, 2014 at 6:38 PM, Sage Weil <sage@xxxxxxxxxxx> wrote: > > Would it make more sense to just rename and export the existing function? > > I'm not sure __ is particularly meaningful in the context of osdmap.c... > > I added a new one because __lookup_pg_pool() takes rb_root, whereas all > existing exported osdmap functions take osdmap. If we were to rename > and export __lookup_pg_pool(), it should probably be changed to take > osdmap. What do you say? Oh, missed that. I think it's fine as it is then. sage > > Thanks, > > Ilya > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html