Would it make more sense to just rename and export the existing function?
I'm not sure __ is particularly meaningful in the context of osdmap.c...
sage
On Mon, 27 Jan 2014, Ilya Dryomov wrote:
> "Lookup pool info by ID" function is hidden in osdmap.c. Expose it to
> the rest of libceph.
>
> Signed-off-by: Ilya Dryomov <ilya.dryomov@xxxxxxxxxxx>
> ---
> include/linux/ceph/osdmap.h | 3 +++
> net/ceph/osdmap.c | 5 +++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/include/linux/ceph/osdmap.h b/include/linux/ceph/osdmap.h
> index ebb8ec285de6..7f894a64c6c7 100644
> --- a/include/linux/ceph/osdmap.h
> +++ b/include/linux/ceph/osdmap.h
> @@ -174,6 +174,9 @@ extern int ceph_calc_pg_acting(struct ceph_osdmap *osdmap,
> extern int ceph_calc_pg_primary(struct ceph_osdmap *osdmap,
> struct ceph_pg pgid);
>
> +extern struct ceph_pg_pool_info *ceph_pg_pool_by_id(struct ceph_osdmap *map,
> + u64 id);
> +
> extern const char *ceph_pg_pool_name_by_id(struct ceph_osdmap *map, u64 id);
> extern int ceph_pg_poolid_by_name(struct ceph_osdmap *map, const char *name);
>
> diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c
> index 768dd04eb9b1..d69d23556f0c 100644
> --- a/net/ceph/osdmap.c
> +++ b/net/ceph/osdmap.c
> @@ -464,6 +464,11 @@ static struct ceph_pg_pool_info *__lookup_pg_pool(struct rb_root *root, u64 id)
> return NULL;
> }
>
> +struct ceph_pg_pool_info *ceph_pg_pool_by_id(struct ceph_osdmap *map, u64 id)
> +{
> + return __lookup_pg_pool(&map->pg_pools, id);
> +}
> +
> const char *ceph_pg_pool_name_by_id(struct ceph_osdmap *map, u64 id)
> {
> struct ceph_pg_pool_info *pi;
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
