On Mon, Sep 23, 2013 at 1:34 AM, Loic Dachary <loic@xxxxxxxxxxx> wrote:
> Hi,
>
> Unless I'm mistaken, ceph_crc32() is currently used in master via the crc32c() method of bufferlist to:
>
> * encode_with_checksum/decode_with_checksum a PGLog entry
> * Message::decode_message/Message::encode_message a message via calc_*_crc
> * FileJournal::do_read_entry/FileJournal::prepare_single_write a journal entry
> * for information in the report monitory command ( Monitor.cc )
>
> Erasure coded chunks ( i.e. files ) will need checksums. Should this be implemented as an optional feature in ceph/src/os/FileStore.{h,cc} ? If the underlying filesystem does not provide this feature, FileStore would call ceph_crc32 each time the object is modified. A verification method would be exposed and used when scrubbing erasure coded pools.
You mean should checksums be optional in the FileStore, or should we
provide a plugin framework for using things other than crc32, or...?
:)
-Greg
Software Engineer #42 @ http://inktank.com | http://ceph.com
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
