Re: Unique bug in ceph start script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Di, Apr 23, 2013 at 10:01:53 -0700, Sage Weil wrote:
...
> > So in this example two config files with different names but the same
> > content would be copied to hosta. This is not very pretty but it 
> > should work without error.
> 
> It's because of the $pushed_to list.. for #3 it wouldn't re-push 
> ceph.conf.  I pushed a patch that just skips that optimization entirely:
> 
> https://github.com/ceph/ceph/commit/ccbc4dbc6edf09626459ca52a53a72682f541e86
> 
> Look okay to you?

Yes, but I'm not happy with the trap instruction:

  trap "ssh $host rm /tmp/ceph.conf.$unique" EXIT

If the start script exits with or without error, the remote config 
file will be removed from <remote-host>:/tmp - but only for the last 
host (the former trap calls will be overwritten by the last trap
call)! This makes no sense to me.

Best regards
Andreas
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux