On Tue, 23 Apr 2013, Andreas Friedrich wrote: > On Mo, Apr 22, 2013 at 08:39:03 -0700, Sage Weil wrote: > > Hi Sage, > > ... > > Thanks for the report! I think this doesn't quite solve the problem, > > though. If all the items for a given target are processed in order, then > > $unique will be correct, but if you get hosta, hostb, hosta then it will > > be wrong. > ... > > sorry, but I don't recognize why it would be wrong: > > Applying my patch the code would do the following: > > 1. hosta: > Create ceph.conf.uniq1, copy it to hosta and use > ceph.conf.uniq1. > > 2. hostb: > Create ceph.conf.uniq2, copy it to hostb and use > ceph.conf.uniq2. > > 3. hosta: > Create ceph.conf.uniq3, copy it to hosta and use > ceph.conf.uniq3. > > So in this example two config files with different names but the same > content would be copied to hosta. This is not very pretty but it > should work without error. It's because of the $pushed_to list.. for #3 it wouldn't re-push ceph.conf. I pushed a patch that just skips that optimization entirely: https://github.com/ceph/ceph/commit/ccbc4dbc6edf09626459ca52a53a72682f541e86 Look okay to you? Thanks! sage -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
