On Thu, 25 Oct 2012, Noah Watkins wrote: > I pushed out wip-client-unmount for review please. One question: would > we want a new messenger nonce for remounts, as opposed to messenger > nonce per context? This looks good to me. The one change I'd make it to document ceph_shutdown() as deprecated, and indicate that it is equivalent (modulo error handling) to ceph_unmount() + ceph_release(). sage > > - Noah > > On Thu, Oct 25, 2012 at 9:23 AM, Sage Weil <sage@xxxxxxxxxxx> wrote: > > On Thu, 25 Oct 2012, Noah Watkins wrote: > >> I was just take a look at this for libcephfs. Does it make sense to > >> have ceph_release free CephContext, and ceph_unmount with everything > >> else: client, messenger, and mon client? > > > > Yeah... _create and _release should create/release the ceph_mount_info and > > associated cct, and mount/unmount will set up and tear down the Client and > > friends. > > > > sage > > > > > > >> - Noah > >> > >> On Wed, Oct 24, 2012 at 4:32 PM, Noah Watkins <jayhawk@xxxxxxxxxxx> wrote: > >> > On the Java, side being able to do an unmount to free resources, while > >> > still keeping the context, makes things more natural to both explain, > >> > and code. I'm sure this would be true for other language bindings as > >> > well. > >> > > >> > +1 > >> > > >> > > >> > On Wed, Oct 24, 2012 at 4:17 PM, Sage Weil <sage@xxxxxxxxxxx> wrote: > >> >> I'm annoyed that ceph_shutdown() both unmounts and releases the resource, > >> >> but there is a separate _create() and _mount() method. I wonder if it > >> >> makes sense to introduce ceph_umount() and ceph_release() and make > >> >> ceph_shutdown() call them (for compatibility). > >> >> > >> >> I thought librados was a bit cleaner, but it appears to be doing the same > >> >> thing.. meh. (Also, the docs for _shutdown() incorrectly state that > >> >> shutdown isn't needed if rados_connect() fails.. but presumably the > >> >> resource still needs to be freed?) > >> >> > >> >> Is this worth fixing? > >> >> > >> >> sage > >> >> -- > >> >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > >> >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> > >> > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
