> It'd be good to update doc/dev/osd_internals with a description of the > reservations though, maybe expanding > doc/dev/osd_internals/backfill_reservation. Will do. > One other thing I'd like to see made explicit: > > How does this handle upgrades? i.e., what will happen when some OSDs > have this reservation mechanism and some do not? I will introduce a feature bit for recovery reservations. If a replica lacks the mechanism then the primary "grants" itself a reservation from that replica. There will obviously be no need to release the reservation. If the primary lacks the mechanism, recovery proceeds as though none of the replicas have the mechanism (which is to say, exactly how it proceeds today). In either case, an OSD can become heavily loaded if too many recovery operations are occurring at the same time, but it's no worse than the current status quo. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
