Re: [PATCH] doc: Correct Git URL for clone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 2, 2012 at 3:48 AM, Wido den Hollander <wido@xxxxxxxxx> wrote:
> Signed-off-by: Wido den Hollander <wido@xxxxxxxxx>
> ---
>  doc/source/clone-source.rst |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/source/clone-source.rst b/doc/source/clone-source.rst
> index e2bc95d..2236b37 100644
> --- a/doc/source/clone-source.rst
> +++ b/doc/source/clone-source.rst
> @@ -9,7 +9,7 @@ Clone the Source
>  ----------------
>  To clone the Ceph source code repository, execute::
>
> -       git clone git@xxxxxxxxxx:ceph/ceph.git
> +       git clone git://github.com/ceph/ceph.git

Actually, in the world of github, https://github.com/ceph/ceph.git is
the best option. MITM safe and passes through more firewalls. I
amended the patch to say that, and pushed to master. Thank you for
noticing!

(I'm also rewriting the next paragraph after that, as it's both
cumbersome and actually wrong.)


John, the docs at http://ceph.com/docs/master/source/git/ could still
use improvement -- nobody needs a Github account just to clone a
repository. The "Generate SSH keys" and "Add the key" sections belong
under http://ceph.com/docs/master/source/contributing/ -- which then
again should talk about sending patches to mailing list, doing work in
your own fork on Github, perhaps using Github pull requests, etc. This
is the old school explanation, largely copied over from the Linux
kernel: https://github.com/ceph/ceph/blob/master/SubmittingPatches
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [CEPH Users]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux