On 06/06/2012 12:18 AM, Sage Weil wrote: > I'm mildly concerned that if the msg isn't on the con the upper layer > thinks it is it is a bug, and we might be better off keeping this arg and > asserting that con == msg->con... The patch I burned myself on over the weekend actually assumed that the msg->con was available to use by the client code. I.e., it assumed that it was not reset to NULL whenever the message left the connection layer. Making it null like that allows for some run-time verification of things (e.g., BUG_ON(msg->con == NULL)) but those aren't strictly necessary, so we could have msg->con hold whatever non-null value it was last assigned. We could even add a flag to indicate the notion of who "owns" it if we still wanted the verification. I'll just keep it as-is unless you have a strong preference for another option; I'm open. -Alex -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
