I've been going over the Google Coding Style document and noticed a few other things that probably merit discussion/a diff: 1) It says not to use streams, except for logging. We don't do a lot of text output other than logging, but in the few places we do it (program help text, for instance) I believe we use stream.s 2) Under the "Integer Types" section, they prefer not to use unsigned types except for bit patterns. They explicitly state that values which are not allowed to be <0 should be checked with asserts, rather than guaranteed by the type. This isn't the case for any of our current code and I'm not sure it's worth changing. Also, I encourage everybody to note the guidelines on commenting. :) -Greg -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html