On Wed, 18 May 2011, Jim Schutt wrote: > Sage Weil wrote: > > > > > I pushed a patch to the msgr_race branch that catches all four cases (I > > think). Does the fix make sense given what you saw? > > Sorry, I haven't completed much testing; it took me a while > to figure out the fix needs this: > > diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c > index 9c0a9bd..b140dd3 100644 > --- a/net/ceph/messenger.c > +++ b/net/ceph/messenger.c > @@ -2013,6 +2013,7 @@ done: > mutex_unlock(&con->mutex); > done_unlocked: > con->ops->put(con); > + return; > > fault: > mutex_unlock(&con->mutex); > > > Still testing.... Good catch. Let us know how it goes! sge -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
