On 02/24/2011 10:13 AM, Colin McCabe wrote: > On Thu, Feb 24, 2011 at 10:02 AM, Josh Durgin <josh.durgin@xxxxxxxxxxxxx> wrote: >> - aio_create_completion could be moved into Pool since it's only >> used within the context of a pool. (librbd would need this unless >> Pool had a get_rados method). > > Hmm. I'm not seeing the pool dependency for aio_create_completion. It > looks like this has nothing to do with any particular pool. It's just > a callback? My thinking was that the only reason for creating one is for doing aio, which is done on a pool. Looking at the implementation, however, there's no dependency on the RadosClient at all. These could just be constructors of AioCompletion (in the interface and implementation). -Josh Durgin -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
