On Sat, 25 Dec 2010, richard -rw- weinberger wrote: > On Sat, Dec 25, 2010 at 10:24 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: > > On Sat, 25 Dec 2010, richard -rw- weinberger wrote: > > > >> On Sat, Dec 25, 2010 at 7:17 PM, Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: > >> > Hello, > >> > > >> > In net/ceph/ceph_common.c::ceph_destroy_client() the pointer 'client' is > >> > freed by kfree() and subsequently used in a call to dout() - use after > >> > free bug. > >> > >> Not really. %p reads only the address of "client". > >> kfree() does not alter this address. > >> > > > > Ok, I see your point and you are correct. But still, the patch does not > > change behaviour and it makes it absolutely clear that there's no > > use-after-free bug, so it might still have merit... or? > > Your patch does not fix a bug. > I would say it's a style fix. > At this point in time I'd agree. :-) -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
