On Thu, Oct 26, 2023 at 12:41:06PM +0300, Nikolay Aleksandrov wrote:
> static const struct nla_policy netkit_policy[IFLA_NETKIT_MAX + 1] = {
> [IFLA_NETKIT_PEER_INFO] = { .len = sizeof(struct ifinfomsg) },
> - [IFLA_NETKIT_POLICY] = { .type = NLA_U32 },
> - [IFLA_NETKIT_MODE] = { .type = NLA_U32 },
> - [IFLA_NETKIT_PEER_POLICY] = { .type = NLA_U32 },
> + [IFLA_NETKIT_POLICY] = NLA_POLICY_VALIDATE_FN(NLA_U32,
> + netkit_check_policy),
Nik, it's problematic to use NLA_POLICY_VALIDATE_FN() with anything
other than NLA_BINARY. See commit 9e17f99220d1 ("net/sched: act_mpls:
Fix warning during failed attribute validation").
> + [IFLA_NETKIT_MODE] = NLA_POLICY_VALIDATE_FN(NLA_U32,
> + netkit_check_mode),
> + [IFLA_NETKIT_PEER_POLICY] = NLA_POLICY_VALIDATE_FN(NLA_U32,
> + netkit_check_policy),
> [IFLA_NETKIT_PRIMARY] = { .type = NLA_REJECT,
> .reject_message = "Primary attribute is read-only" },
> };
> --
> 2.38.1
>
>
