Re: [PATCHv2 1/2] tools/build: Fix -s detection code in tools/build/Makefile.build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 12, 2023 at 11:37 PM Jiri Olsa <olsajiri@xxxxxxxxx> wrote:
>
> On Thu, Oct 12, 2023 at 08:57:33PM -0700, Namhyung Kim wrote:
> > Hi Jiri,
> >
> > On Sun, Oct 8, 2023 at 2:23 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > >
> > > As Dmitry described in [1] changelog the current way of detecting
> > > -s option is broken for new make.
> >
> > I'm not sure what -s option does for perf (at least).
> > It doesn't seem much different whether I give it or not.
> > Am I missing something?
>
> what's your make version? the wrong output is visible when running
> with make version > 4.4 .. basicaly the -s is wrongly detected and
> you either get no output at all from some builds or overly verbose
> output
>
> it's mentioned in the [1] commit changelog, I can put it to the
> changelog in new version

IIUC it's about detecting `make -s` properly and not being confused
by `make a=s` or something.  I'm not objecting on it but I don't see
what `make -s` does actually.

Anyway, my make version is 4.3.

Thanks,
Namhyung





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux