Hi Jiri,
On Sun, Oct 8, 2023 at 2:23 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> As Dmitry described in [1] changelog the current way of detecting
> -s option is broken for new make.
I'm not sure what -s option does for perf (at least).
It doesn't seem much different whether I give it or not.
Am I missing something?
Thanks,
Namhyung
>
> Changing the tools/build -s option detection the same way as it was
> fixed for root Makefile in [1].
>
> [1] 4bf73588165b ("kbuild: Port silent mode detection to future gnu make.")
>
> Cc: Dmitry Goncharov <dgoncharov@xxxxxxxxxxxx>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
> tools/build/Makefile.build | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index fac42486a8cf..5fb3fb3d97e0 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -20,7 +20,15 @@ else
> Q=@
> endif
>
> -ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
> +# If the user is running make -s (silent mode), suppress echoing of commands
> +# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS.
> +ifeq ($(filter 3.%,$(MAKE_VERSION)),)
> +short-opts := $(firstword -$(MAKEFLAGS))
> +else
> +short-opts := $(filter-out --%,$(MAKEFLAGS))
> +endif
> +
> +ifneq ($(findstring s,$(short-opts)),)
> quiet=silent_
> endif
>
> --
> 2.41.0
>
