Victor Nogueira <victor@xxxxxxxxxxxx> wrote:
> + FN(TC_ALLOC_SKB_EXT) \
I think that SKB_DROP_REASON_NOMEM is fine for this, adding
a new drop reason for every type of object alloction failure
doesn't help.
The other ones are things that do point at tc specific config problems
so no objections there.
> ext = tc_skb_ext_alloc(skb);
> - if (WARN_ON_ONCE(!ext))
> + if (WARN_ON_ONCE(!ext)) {
> + u32 drop_reason = SKB_TC_ALLOC_SKB_EXT;
> +
> + tcf_set_drop_reason(res, drop_reason);
Unrelated to your patch, but I think this WARN_ON makes no sense.
There is nothing the user or a developer could do about that GFP_ATOMIC failure.
Also I see this patch gets rid of some, but not all, CONFIG_NET_CLS_ACT ifdefs.
The changelog should mention why.
Otherwise this LGTM.
