Hi Chuyi, kernel test robot noticed the following build warnings: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Chuyi-Zhou/cgroup-Prepare-for-using-css_task_iter_-in-BPF/20230912-150454 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20230912070149.969939-5-zhouchuyi%40bytedance.com patch subject: [PATCH bpf-next v2 4/6] bpf: Introduce css_descendant open-coded iterator kfuncs config: hexagon-randconfig-r032-20230913 (https://download.01.org/0day-ci/archive/20230913/202309131621.h5ogfV0Z-lkp@xxxxxxxxx/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230913/202309131621.h5ogfV0Z-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309131621.h5ogfV0Z-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from kernel/bpf/task_iter.c:9: In file included from include/linux/filter.h:9: In file included from include/linux/bpf.h:31: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:26: In file included from include/linux/kernel_stat.h:9: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:13: In file included from arch/hexagon/include/asm/io.h:337: include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 584 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ kernel/bpf/task_iter.c:820:7: error: use of undeclared identifier 'CSS_TASK_ITER_PROCS' 820 | case CSS_TASK_ITER_PROCS | CSS_TASK_ITER_THREADED: | ^ kernel/bpf/task_iter.c:820:29: error: use of undeclared identifier 'CSS_TASK_ITER_THREADED' 820 | case CSS_TASK_ITER_PROCS | CSS_TASK_ITER_THREADED: | ^ kernel/bpf/task_iter.c:821:7: error: use of undeclared identifier 'CSS_TASK_ITER_PROCS' 821 | case CSS_TASK_ITER_PROCS: | ^ kernel/bpf/task_iter.c:828:24: error: invalid application of 'sizeof' to an incomplete type 'struct css_task_iter' 828 | kit->css_it = kzalloc(sizeof(struct css_task_iter), GFP_KERNEL); | ^ ~~~~~~~~~~~~~~~~~~~~~~ kernel/bpf/task_iter.c:807:9: note: forward declaration of 'struct css_task_iter' 807 | struct css_task_iter *css_it; | ^ kernel/bpf/task_iter.c:831:2: error: call to undeclared function 'css_task_iter_start'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 831 | css_task_iter_start(css, flags, kit->css_it); | ^ kernel/bpf/task_iter.c:831:2: note: did you mean '__sg_page_iter_start'? include/linux/scatterlist.h:573:6: note: '__sg_page_iter_start' declared here 573 | void __sg_page_iter_start(struct sg_page_iter *piter, | ^ kernel/bpf/task_iter.c:810:17: warning: no previous prototype for function 'bpf_iter_css_task_new' [-Wmissing-prototypes] 810 | __bpf_kfunc int bpf_iter_css_task_new(struct bpf_iter_css_task *it, | ^ kernel/bpf/task_iter.c:810:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 810 | __bpf_kfunc int bpf_iter_css_task_new(struct bpf_iter_css_task *it, | ^ | static kernel/bpf/task_iter.c:841:9: error: call to undeclared function 'css_task_iter_next'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 841 | return css_task_iter_next(kit->css_it); | ^ kernel/bpf/task_iter.c:841:9: error: incompatible integer to pointer conversion returning 'int' from a function with result type 'struct task_struct *' [-Wint-conversion] 841 | return css_task_iter_next(kit->css_it); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/bpf/task_iter.c:835:33: warning: no previous prototype for function 'bpf_iter_css_task_next' [-Wmissing-prototypes] 835 | __bpf_kfunc struct task_struct *bpf_iter_css_task_next(struct bpf_iter_css_task *it) | ^ kernel/bpf/task_iter.c:835:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 835 | __bpf_kfunc struct task_struct *bpf_iter_css_task_next(struct bpf_iter_css_task *it) | ^ | static kernel/bpf/task_iter.c:850:2: error: call to undeclared function 'css_task_iter_end'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 850 | css_task_iter_end(kit->css_it); | ^ kernel/bpf/task_iter.c:844:18: warning: no previous prototype for function 'bpf_iter_css_task_destroy' [-Wmissing-prototypes] 844 | __bpf_kfunc void bpf_iter_css_task_destroy(struct bpf_iter_css_task *it) | ^ kernel/bpf/task_iter.c:844:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 844 | __bpf_kfunc void bpf_iter_css_task_destroy(struct bpf_iter_css_task *it) | ^ | static kernel/bpf/task_iter.c:858:17: warning: no previous prototype for function 'bpf_iter_process_new' [-Wmissing-prototypes] 858 | __bpf_kfunc int bpf_iter_process_new(struct bpf_iter_process *it) | ^ kernel/bpf/task_iter.c:858:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 858 | __bpf_kfunc int bpf_iter_process_new(struct bpf_iter_process *it) | ^ | static kernel/bpf/task_iter.c:870:33: warning: no previous prototype for function 'bpf_iter_process_next' [-Wmissing-prototypes] 870 | __bpf_kfunc struct task_struct *bpf_iter_process_next(struct bpf_iter_process *it) | ^ kernel/bpf/task_iter.c:870:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 870 | __bpf_kfunc struct task_struct *bpf_iter_process_next(struct bpf_iter_process *it) | ^ | static kernel/bpf/task_iter.c:879:18: warning: no previous prototype for function 'bpf_iter_process_destroy' [-Wmissing-prototypes] 879 | __bpf_kfunc void bpf_iter_process_destroy(struct bpf_iter_process *it) | ^ kernel/bpf/task_iter.c:879:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 879 | __bpf_kfunc void bpf_iter_process_destroy(struct bpf_iter_process *it) | ^ | static >> kernel/bpf/task_iter.c:888:17: warning: no previous prototype for function 'bpf_iter_css_pre_new' [-Wmissing-prototypes] 888 | __bpf_kfunc int bpf_iter_css_pre_new(struct bpf_iter_css_pre *it, | ^ kernel/bpf/task_iter.c:888:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 888 | __bpf_kfunc int bpf_iter_css_pre_new(struct bpf_iter_css_pre *it, | ^ | static kernel/bpf/task_iter.c:904:13: error: call to undeclared function 'css_next_descendant_pre'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 904 | kit->pos = css_next_descendant_pre(kit->pos, kit->root); | ^ kernel/bpf/task_iter.c:904:11: error: incompatible integer to pointer conversion assigning to 'struct cgroup_subsys_state *' from 'int' [-Wint-conversion] 904 | kit->pos = css_next_descendant_pre(kit->pos, kit->root); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:900:41: warning: no previous prototype for function 'bpf_iter_css_pre_next' [-Wmissing-prototypes] 900 | __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_pre_next(struct bpf_iter_css_pre *it) | ^ kernel/bpf/task_iter.c:900:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 900 | __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_pre_next(struct bpf_iter_css_pre *it) | ^ | static >> kernel/bpf/task_iter.c:908:18: warning: no previous prototype for function 'bpf_iter_css_pre_destroy' [-Wmissing-prototypes] 908 | __bpf_kfunc void bpf_iter_css_pre_destroy(struct bpf_iter_css_pre *it) | ^ kernel/bpf/task_iter.c:908:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 908 | __bpf_kfunc void bpf_iter_css_pre_destroy(struct bpf_iter_css_pre *it) | ^ | static >> kernel/bpf/task_iter.c:912:17: warning: no previous prototype for function 'bpf_iter_css_post_new' [-Wmissing-prototypes] 912 | __bpf_kfunc int bpf_iter_css_post_new(struct bpf_iter_css_post *it, | ^ kernel/bpf/task_iter.c:912:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 912 | __bpf_kfunc int bpf_iter_css_post_new(struct bpf_iter_css_post *it, | ^ | static kernel/bpf/task_iter.c:928:13: error: call to undeclared function 'css_next_descendant_post'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 928 | kit->pos = css_next_descendant_post(kit->pos, kit->root); | ^ kernel/bpf/task_iter.c:928:11: error: incompatible integer to pointer conversion assigning to 'struct cgroup_subsys_state *' from 'int' [-Wint-conversion] 928 | kit->pos = css_next_descendant_post(kit->pos, kit->root); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:924:41: warning: no previous prototype for function 'bpf_iter_css_post_next' [-Wmissing-prototypes] 924 | __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_post_next(struct bpf_iter_css_post *it) | ^ kernel/bpf/task_iter.c:924:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 924 | __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_post_next(struct bpf_iter_css_post *it) | ^ | static >> kernel/bpf/task_iter.c:932:18: warning: no previous prototype for function 'bpf_iter_css_post_destroy' [-Wmissing-prototypes] 932 | __bpf_kfunc void bpf_iter_css_post_destroy(struct bpf_iter_css_post *it) | ^ kernel/bpf/task_iter.c:932:13: note: declare 'static' if the function is not intended to be used outside of this translation unit 932 | __bpf_kfunc void bpf_iter_css_post_destroy(struct bpf_iter_css_post *it) | ^ | static 18 warnings and 12 errors generated. vim +/bpf_iter_css_pre_new +888 kernel/bpf/task_iter.c 878 > 879 __bpf_kfunc void bpf_iter_process_destroy(struct bpf_iter_process *it) 880 { 881 } 882 883 struct bpf_iter_css_kern { 884 struct cgroup_subsys_state *root; 885 struct cgroup_subsys_state *pos; 886 } __attribute__((aligned(8))); 887 > 888 __bpf_kfunc int bpf_iter_css_pre_new(struct bpf_iter_css_pre *it, 889 struct cgroup_subsys_state *root) 890 { 891 struct bpf_iter_css_kern *kit = (void *)it; 892 893 BUILD_BUG_ON(sizeof(struct bpf_iter_css_kern) != sizeof(struct bpf_iter_css_pre)); 894 BUILD_BUG_ON(__alignof__(struct bpf_iter_css_kern) != __alignof__(struct bpf_iter_css_pre)); 895 kit->root = root; 896 kit->pos = NULL; 897 return 0; 898 } 899 > 900 __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_pre_next(struct bpf_iter_css_pre *it) 901 { 902 struct bpf_iter_css_kern *kit = (void *)it; 903 > 904 kit->pos = css_next_descendant_pre(kit->pos, kit->root); 905 return kit->pos; 906 } 907 > 908 __bpf_kfunc void bpf_iter_css_pre_destroy(struct bpf_iter_css_pre *it) 909 { 910 } 911 > 912 __bpf_kfunc int bpf_iter_css_post_new(struct bpf_iter_css_post *it, 913 struct cgroup_subsys_state *root) 914 { 915 struct bpf_iter_css_kern *kit = (void *)it; 916 917 BUILD_BUG_ON(sizeof(struct bpf_iter_css_kern) != sizeof(struct bpf_iter_css_post)); 918 BUILD_BUG_ON(__alignof__(struct bpf_iter_css_kern) != __alignof__(struct bpf_iter_css_post)); 919 kit->root = root; 920 kit->pos = NULL; 921 return 0; 922 } 923 > 924 __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_post_next(struct bpf_iter_css_post *it) 925 { 926 struct bpf_iter_css_kern *kit = (void *)it; 927 > 928 kit->pos = css_next_descendant_post(kit->pos, kit->root); 929 return kit->pos; 930 } 931 > 932 __bpf_kfunc void bpf_iter_css_post_destroy(struct bpf_iter_css_post *it) 933 { 934 } 935 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
