Hi Chuyi, kernel test robot noticed the following build warnings: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Chuyi-Zhou/cgroup-Prepare-for-using-css_task_iter_-in-BPF/20230912-150454 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master patch link: https://lore.kernel.org/r/20230912070149.969939-5-zhouchuyi%40bytedance.com patch subject: [PATCH bpf-next v2 4/6] bpf: Introduce css_descendant open-coded iterator kfuncs config: s390-defconfig (https://download.01.org/0day-ci/archive/20230913/202309131500.J19z0Dil-lkp@xxxxxxxxx/config) compiler: s390-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230913/202309131500.J19z0Dil-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309131500.J19z0Dil-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): kernel/bpf/task_iter.c:810:17: warning: no previous prototype for 'bpf_iter_css_task_new' [-Wmissing-prototypes] 810 | __bpf_kfunc int bpf_iter_css_task_new(struct bpf_iter_css_task *it, | ^~~~~~~~~~~~~~~~~~~~~ kernel/bpf/task_iter.c:835:33: warning: no previous prototype for 'bpf_iter_css_task_next' [-Wmissing-prototypes] 835 | __bpf_kfunc struct task_struct *bpf_iter_css_task_next(struct bpf_iter_css_task *it) | ^~~~~~~~~~~~~~~~~~~~~~ kernel/bpf/task_iter.c:844:18: warning: no previous prototype for 'bpf_iter_css_task_destroy' [-Wmissing-prototypes] 844 | __bpf_kfunc void bpf_iter_css_task_destroy(struct bpf_iter_css_task *it) | ^~~~~~~~~~~~~~~~~~~~~~~~~ kernel/bpf/task_iter.c:858:17: warning: no previous prototype for 'bpf_iter_process_new' [-Wmissing-prototypes] 858 | __bpf_kfunc int bpf_iter_process_new(struct bpf_iter_process *it) | ^~~~~~~~~~~~~~~~~~~~ kernel/bpf/task_iter.c:870:33: warning: no previous prototype for 'bpf_iter_process_next' [-Wmissing-prototypes] 870 | __bpf_kfunc struct task_struct *bpf_iter_process_next(struct bpf_iter_process *it) | ^~~~~~~~~~~~~~~~~~~~~ kernel/bpf/task_iter.c:879:18: warning: no previous prototype for 'bpf_iter_process_destroy' [-Wmissing-prototypes] 879 | __bpf_kfunc void bpf_iter_process_destroy(struct bpf_iter_process *it) | ^~~~~~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:888:17: warning: no previous prototype for 'bpf_iter_css_pre_new' [-Wmissing-prototypes] 888 | __bpf_kfunc int bpf_iter_css_pre_new(struct bpf_iter_css_pre *it, | ^~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:900:41: warning: no previous prototype for 'bpf_iter_css_pre_next' [-Wmissing-prototypes] 900 | __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_pre_next(struct bpf_iter_css_pre *it) | ^~~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:908:18: warning: no previous prototype for 'bpf_iter_css_pre_destroy' [-Wmissing-prototypes] 908 | __bpf_kfunc void bpf_iter_css_pre_destroy(struct bpf_iter_css_pre *it) | ^~~~~~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:912:17: warning: no previous prototype for 'bpf_iter_css_post_new' [-Wmissing-prototypes] 912 | __bpf_kfunc int bpf_iter_css_post_new(struct bpf_iter_css_post *it, | ^~~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:924:41: warning: no previous prototype for 'bpf_iter_css_post_next' [-Wmissing-prototypes] 924 | __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_post_next(struct bpf_iter_css_post *it) | ^~~~~~~~~~~~~~~~~~~~~~ >> kernel/bpf/task_iter.c:932:18: warning: no previous prototype for 'bpf_iter_css_post_destroy' [-Wmissing-prototypes] 932 | __bpf_kfunc void bpf_iter_css_post_destroy(struct bpf_iter_css_post *it) | ^~~~~~~~~~~~~~~~~~~~~~~~~ vim +/bpf_iter_css_pre_new +888 kernel/bpf/task_iter.c 887 > 888 __bpf_kfunc int bpf_iter_css_pre_new(struct bpf_iter_css_pre *it, 889 struct cgroup_subsys_state *root) 890 { 891 struct bpf_iter_css_kern *kit = (void *)it; 892 893 BUILD_BUG_ON(sizeof(struct bpf_iter_css_kern) != sizeof(struct bpf_iter_css_pre)); 894 BUILD_BUG_ON(__alignof__(struct bpf_iter_css_kern) != __alignof__(struct bpf_iter_css_pre)); 895 kit->root = root; 896 kit->pos = NULL; 897 return 0; 898 } 899 > 900 __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_pre_next(struct bpf_iter_css_pre *it) 901 { 902 struct bpf_iter_css_kern *kit = (void *)it; 903 904 kit->pos = css_next_descendant_pre(kit->pos, kit->root); 905 return kit->pos; 906 } 907 > 908 __bpf_kfunc void bpf_iter_css_pre_destroy(struct bpf_iter_css_pre *it) 909 { 910 } 911 > 912 __bpf_kfunc int bpf_iter_css_post_new(struct bpf_iter_css_post *it, 913 struct cgroup_subsys_state *root) 914 { 915 struct bpf_iter_css_kern *kit = (void *)it; 916 917 BUILD_BUG_ON(sizeof(struct bpf_iter_css_kern) != sizeof(struct bpf_iter_css_post)); 918 BUILD_BUG_ON(__alignof__(struct bpf_iter_css_kern) != __alignof__(struct bpf_iter_css_post)); 919 kit->root = root; 920 kit->pos = NULL; 921 return 0; 922 } 923 > 924 __bpf_kfunc struct cgroup_subsys_state *bpf_iter_css_post_next(struct bpf_iter_css_post *it) 925 { 926 struct bpf_iter_css_kern *kit = (void *)it; 927 928 kit->pos = css_next_descendant_post(kit->pos, kit->root); 929 return kit->pos; 930 } 931 > 932 __bpf_kfunc void bpf_iter_css_post_destroy(struct bpf_iter_css_post *it) 933 { 934 } 935 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
