Re: [PATCHv2 bpf-next 1/9] bpf: Count stats for kprobe_multi programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 7, 2023 at 12:13 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
nit: The subject doesn't state "missed stats".
>
> Adding support to gather missed stats for kprobe_multi
> programs due to bpf_prog_active protection.
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Other than that

Reviewed-and-tested-by: Song Liu <song@xxxxxxxxxx>

> ---
>  kernel/trace/bpf_trace.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index a7264b2c17ad..279a3d370812 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -2710,6 +2710,7 @@ kprobe_multi_link_prog_run(struct bpf_kprobe_multi_link *link,
>         int err;
>
>         if (unlikely(__this_cpu_inc_return(bpf_prog_active) != 1)) {
> +               bpf_prog_inc_misses_counter(link->link.prog);
>                 err = 0;
>                 goto out;
>         }
> --
> 2.41.0
>
>





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux