On 07/09/2023 09:56, Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at
Cisco) wrote:
>> If I follow correctly, the cast was added in bpftool in a6cc6b34b93e
>> ("bpftool: Provide a helper method for accessing skeleton's embedded ELF
>> data"), which mentions indeed:
>>
>> The assignment to s->data is cast to void * to ensure no warning is
>> issued if compiled with a previous version of libbpf where the
>> bpf_object_skeleton field is void * instead of const void *
>>
>> but in libbpf, s->data's type had already been changed since commit
>> 08a6f22ef6f8 ("libbpf: Change bpf_object_skeleton data field to const
>> pointer"), part of libbpf 0.6, is this correct?
> yes, this is correct
>
OK, thanks
Acked-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>
