On 04/08/2023 2:48, Martin KaFai Lau wrote: > On 8/3/23 4:10 AM, Gal Pressman wrote: >> On 22/07/2023 2:33, Daniel Borkmann wrote: >>> On qdisc destruction, the ingress_destroy() needs to update the correct >>> entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer. >>> Therefore, fix the typo. >>> >>> Fixes: e420bed02507 ("bpf: Add fd-based tcx multi-prog infra with >>> link support") >>> Reported-by: syzbot+bdcf141f362ef83335cf@xxxxxxxxxxxxxxxxxxxxxxxxx >>> Reported-by: syzbot+b202b7208664142954fa@xxxxxxxxxxxxxxxxxxxxxxxxx >>> Reported-by: syzbot+14736e249bce46091c18@xxxxxxxxxxxxxxxxxxxxxxxxx >>> Signed-off-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx> >> >> Hi Daniel, >> >> Our nightly regression testing picked up new memory leaks which were >> bisected to this commit. > > Thanks for the report. Can you help to check if it can be reproduced > with the latest net-next which has a tcx fix in commit 079082c60aff > ("tcx: Fix splat during dev unregister")? > I think the issue is resolved after this patch, but we're still verifying. Thanks!