On 04/08/2023 16:31, Ido Schimmel wrote:
> On Thu, Aug 03, 2023 at 02:10:51PM +0300, Gal Pressman wrote:
>> Our nightly regression testing picked up new memory leaks which were
>> bisected to this commit.
>> Unfortunately, I do not know the exact repro steps to trigger it, maybe
>> the attached kmemeleak logs can help?
>
> [...]
>
>> unreferenced object 0xffff88812acdebc0 (size 16):
>> comm "umount.nfs", pid 11626, jiffies 4295354796 (age 45.472s)
>> hex dump (first 16 bytes):
>> 73 65 72 76 65 72 2d 32 00 eb cd 2a 81 88 ff ff server-2...*....
>> backtrace:
>> [<0000000010fb5130>] __kmalloc_node_track_caller+0x4c/0x170
>> [<00000000b866a733>] kvasprintf+0xb0/0x130
>> [<00000000b3564fca>] kasprintf+0xa6/0xd0
>> [<00000000f01d6cb3>] nfs_sysfs_move_sb_to_server+0x49/0xd0
>> [<000000009608708f>] nfs_kill_super+0x5f/0x90
>> [<0000000090d4108b>] deactivate_locked_super+0x80/0x130
>> [<000000000856aeb1>] cleanup_mnt+0x258/0x370
>> [<0000000040582e39>] task_work_run+0x12c/0x210
>> [<00000000378ea041>] exit_to_user_mode_prepare+0x1a0/0x1b0
>> [<00000000025e63dd>] syscall_exit_to_user_mode+0x19/0x50
>> [<00000000f34ad3ee>] do_syscall_64+0x4a/0x90
>> [<000000009d3e2403>] entry_SYSCALL_64_after_hwframe+0x46/0xb0
>
> This one is caused by commit 1c7251187dc0 ("NFS: add superblock sysfs
> entries") and fixed by [1], so I'm not sure the bisection result is
> reliable.
>
> [1] https://lore.kernel.org/linux-nfs/6702796fee0365bf399800326bbe6c88e5f73f68.1689014440.git.bcodding@xxxxxxxxxx/
Thanks, maybe there is more than one issue lurking.
We ran the bisect a few times, it always came back to this commit.
