Re: [PATCH v3 bpf-next 2/2] selftests/bpf: Add selftest for fill_link_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 3, 2023 at 4:57 AM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Mon, Jul 31, 2023 at 4:13 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote:
> >
> > Add selftest for the fill_link_info of uprobe, kprobe and tracepoint.
> > The result:
> >
> >   $ tools/testing/selftests/bpf/test_progs --name=fill_link_info
> >   #79/1    fill_link_info/kprobe_link_info:OK
> >   #79/2    fill_link_info/kretprobe_link_info:OK
> >   #79/3    fill_link_info/kprobe_fill_invalid_user_buff:OK
> >   #79/4    fill_link_info/tracepoint_link_info:OK
> >   #79/5    fill_link_info/uprobe_link_info:OK
> >   #79/6    fill_link_info/uretprobe_link_info:OK
> >   #79/7    fill_link_info/kprobe_multi_link_info:OK
> >   #79/8    fill_link_info/kretprobe_multi_link_info:OK
> >   #79/9    fill_link_info/kprobe_multi_ubuff:OK
> >   #79      fill_link_info:OK
> >   Summary: 1/9 PASSED, 0 SKIPPED, 0 FAILED
> >
> > The test case for kprobe_multi won't be run on aarch64, as it is not
> > supported.
> >
> > Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx>
> > ---
> >  tools/testing/selftests/bpf/DENYLIST.aarch64       |   3 +
> >  .../selftests/bpf/prog_tests/fill_link_info.c      | 369 +++++++++++++++++++++
> >  .../selftests/bpf/progs/test_fill_link_info.c      |  42 +++
> >  3 files changed, 414 insertions(+)
> >  create mode 100644 tools/testing/selftests/bpf/prog_tests/fill_link_info.c
> >  create mode 100644 tools/testing/selftests/bpf/progs/test_fill_link_info.c
> >
> > diff --git a/tools/testing/selftests/bpf/DENYLIST.aarch64 b/tools/testing/selftests/bpf/DENYLIST.aarch64
> > index 3b61e8b..b2f46b6 100644
> > --- a/tools/testing/selftests/bpf/DENYLIST.aarch64
> > +++ b/tools/testing/selftests/bpf/DENYLIST.aarch64
> > @@ -12,3 +12,6 @@ kprobe_multi_test/skel_api                       # libbpf: failed to load BPF sk
> >  module_attach                                    # prog 'kprobe_multi': failed to auto-attach: -95
> >  fentry_test/fentry_many_args                     # fentry_many_args:FAIL:fentry_many_args_attach unexpected error: -524
> >  fexit_test/fexit_many_args                       # fexit_many_args:FAIL:fexit_many_args_attach unexpected error: -524
> > +fill_link_info/kprobe_multi_link_info            # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > +fill_link_info/kretprobe_multi_link_info         # bpf_program__attach_kprobe_multi_opts unexpected error: -95
> > +fill_link_info/kprobe_multi_ubuff                # bpf_program__attach_kprobe_multi_opts unexpected error: -95
>
>
> BPF CI isn't happy, because s390 also needs to be updated?

I thought it was caused by other issues. The s390 server may not be so stable.
kprobe_multi is supported by s390. Before sending this series, I have
verified the BPF CI on github, and it can run successfully on s390 :
https://github.com/kernel-patches/bpf/actions/runs/5711429876/job/15473251677#step:6:4972

> We'll just mark patches as 'changes requested' next time without
> explicit emails.


-- 
Regards
Yafang





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux