On Tue, Aug 1, 2023 at 5:33 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > While poking at struct netdev_rx_queue I got annoyed by > the huge rebuild times. I split it out from netdevice.h > and then realized that it was the main reason we included > xdp.h in there. So I removed that dependency as well. > > This gives us very pleasant build times for both xdp.h > and struct netdev_rx_queue changes. > > I'm sending this for bpf-next because I think it'd be easiest > if it goes in there, and then bpf-next gets flushed soon after? > I can also make a branch on merge-base for net-next and bpf-next.. Sounds like a plan to me. Especially considering that targeting bpf-next will exercise BPF CI... and it's not happy at the moment: ../net/netfilter/nf_conntrack_bpf.c: In function ‘bpf_xdp_ct_alloc’: ../net/netfilter/nf_conntrack_bpf.c:258:44: error: dereferencing pointer to incomplete type ‘struct xdp_buff’ 258 | nfct = __bpf_nf_ct_alloc_entry(dev_net(ctx->rxq->dev), bpf_tuple, tuple__sz, |