Re: [PATCH bpf-next v6 2/8] bpf: Add fd-based tcx multi-prog infra with link support

[Daniel Borkmann <daniel@xxxxxxxxxxxxx>]

On 7/20/23 4:13 AM, Yafang Shao wrote:
> On Wed, Jul 19, 2023 at 10:11 PM Daniel Borkmann <daniel@xxxxxxxxxxxxx> wrote:
[...]
> > +static const struct bpf_link_ops tcx_link_lops = {
> > +       .release        = tcx_link_release,
> > +       .detach         = tcx_link_detach,
> > +       .dealloc        = tcx_link_dealloc,
> > +       .update_prog    = tcx_link_update,
> > +       .show_fdinfo    = tcx_link_fdinfo,
> > +       .fill_link_info = tcx_link_fill_info,
>
> Should we show the tc link info in `bpftool link show` as well? I
> believe that `bpftool link show` is the appropriate command to display
> comprehensive information about all links.

Yep, good idea. I'll add this to my todo list to tackle for once I'm back
from travel.

Thanks,
Daniel