On 2023/7/21 0:22, Jakub Kicinski wrote: > On Thu, 20 Jul 2023 19:07:31 +0800 Yunsheng Lin wrote: >>> BTW, what do you think: is it better to have those two includes in the >>> root include/net/ folder or do something like >>> >>> include/net/page_pool/ >>> * types.h >>> * <some meaningful name>.h (let's say driver.h) >>> >>> like it's done e.g. for GPIO (see include/linux/gpio/)? >> >> It make more sense to add a new dir for page pool if there are >> more new headers added. As we are still keeping the page_pool.h >> mirroring include/linux/gpio.h, adding a new dir for only one >> header file only add another level of dir without abvious benefit. >> We can add a new dir for it if we turn out to be needing more header >> file for page pool in the future, does it make sense? > > It doesn't matter all that much so I think to have some uniformity > in networking please go with Olek's suggestion which is also my > preference. Just to be clear, include/net/page_pool.h is still there, we are not putting page_pool.h in include/net/page_pool/ and renaming it to something else, right? As there is no that kind of uniformity in include/net/* as far as I can see. More specificly, yon means the below, right? include/net/page_pool.h include/net/page_pool/types.h > . >
