On 2023/7/20 0:42, Alexander Lobakin wrote: > > BTW, what do you think: is it better to have those two includes in the > root include/net/ folder or do something like > > include/net/page_pool/ > * types.h > * <some meaningful name>.h (let's say driver.h) > > like it's done e.g. for GPIO (see include/linux/gpio/)? It make more sense to add a new dir for page pool if there are more new headers added. As we are still keeping the page_pool.h mirroring include/linux/gpio.h, adding a new dir for only one header file only add another level of dir without abvious benefit. We can add a new dir for it if we turn out to be needing more header file for page pool in the future, does it make sense? > > Thanks, > Olek > > . >