Re: [v3 PATCH bpf-next 5/6] selftests/bpf: test map percpu stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 7/4/2023 11:23 PM, Anton Protopopov wrote:
> On Tue, Jul 04, 2023 at 03:02:32PM +0000, Anton Protopopov wrote:
>> On Tue, Jul 04, 2023 at 10:41:10PM +0800, Hou Tao wrote:
>>> Hi,
>>>
>>> On 6/30/2023 4:25 PM, Anton Protopopov wrote:
>>> [...]
>>>> +}
>>>> +
>>>> +void test_map_percpu_stats(void)
>>>> +{
>>>> +	map_percpu_stats_hash();
>>>> +	map_percpu_stats_percpu_hash();
>>>> +	map_percpu_stats_hash_prealloc();
>>>> +	map_percpu_stats_percpu_hash_prealloc();
>>>> +	map_percpu_stats_lru_hash();
>>>> +	map_percpu_stats_percpu_lru_hash();
>>>> +}
>>> Please use test__start_subtest() to create multiple subtests.
> After looking at code, I think that I will leave the individual functions here,
> as the test__start_subtest() function is only implemented in test_progs (not
> test_maps), and adding it here looks like out of scope for this patch.
> .
I see. But can we just add these tests in test_progs instead which is
more flexible ?





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux