On Tue, Jul 04, 2023 at 03:23:30PM +0000, Anton Protopopov wrote:
> On Tue, Jul 04, 2023 at 03:02:32PM +0000, Anton Protopopov wrote:
> > On Tue, Jul 04, 2023 at 10:41:10PM +0800, Hou Tao wrote:
> > > Hi,
> > >
> > > On 6/30/2023 4:25 PM, Anton Protopopov wrote:
> > > [...]
> > > > +}
> > > > +
> > > > +void test_map_percpu_stats(void)
> > > > +{
> > > > + map_percpu_stats_hash();
> > > > + map_percpu_stats_percpu_hash();
> > > > + map_percpu_stats_hash_prealloc();
> > > > + map_percpu_stats_percpu_hash_prealloc();
> > > > + map_percpu_stats_lru_hash();
> > > > + map_percpu_stats_percpu_lru_hash();
> > > > +}
> > >
> > > Please use test__start_subtest() to create multiple subtests.
>
> After looking at code, I think that I will leave the individual functions here,
> as the test__start_subtest() function is only implemented in test_progs (not
> test_maps), and adding it here looks like out of scope for this patch.
Ah, sorry, looks like the same stands for ASSERT* macros as well, as they are
only used in test_progs. (I will still fix the checks where you commented on
specific values, like n <= cur_elems for LRUs.)
