On Wed, Apr 12, 2023 at 9:43 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > On Wed, Apr 12, 2023 at 12:07 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote: > > On Wed, Apr 12, 2023 at 2:28 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > On Wed, Apr 12, 2023 at 02:06:23PM -0400, Paul Moore wrote: > > > > On Wed, Apr 12, 2023 at 1:47 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > > On Wed, Apr 12, 2023 at 12:49:06PM -0400, Paul Moore wrote: > > > > > > On Wed, Apr 12, 2023 at 12:33 AM Andrii Nakryiko <andrii@xxxxxxxxxx> wrote: ... > > > > > For example, in many places we have things like: > > > > > > > > > > if (!some_check(...) && !capable(...)) > > > > > return -EPERM; > > > > > > > > > > I would expect this is a similar logic. An operation can succeed if the > > > > > access control requirement is met. The mismatch we have through-out the > > > > > kernel is that capability checks aren't strictly done by LSM hooks. And > > > > > this series conceptually, I think, doesn't violate that -- it's changing > > > > > the logic of the capability checks, not the LSM (i.e. there no LSM hooks > > > > > yet here). > > > > > > > > Patch 04/08 creates a new LSM hook, security_bpf_map_create(), which > > > > when it returns a positive value "bypasses kernel checks". The patch > > > > isn't based on either Linus' tree or the LSM tree, I'm guessing it is > > > > based on a eBPF tree, so I can't say with 100% certainty that it is > > > > bypassing a capability check, but the description claims that to be > > > > the case. > > > > > > > > Regardless of how you want to spin this, I'm not supportive of a LSM > > > > hook which allows a LSM to bypass a capability check. A LSM hook can > > > > be used to provide additional access control restrictions beyond a > > > > capability check, but a LSM hook should never be allowed to overrule > > > > an access denial due to a capability check. > > > > > > > > > The reason CAP_BPF was created was because there was nothing else that > > > > > would be fine-grained enough at the time. > > > > > > > > The LSM layer predates CAP_BPF, and one could make a very solid > > > > argument that one of the reasons LSMs exist is to provide > > > > supplementary controls due to capability-based access controls being a > > > > poor fit for many modern use cases. > > > > > > I generally agree with what you say, but we DO have this code pattern: > > > > > > if (!some_check(...) && !capable(...)) > > > return -EPERM; > > > > I think we need to make this more concrete; we don't have a pattern in > > the upstream kernel where 'some_check(...)' is a LSM hook, right? > > Simply because there is another kernel access control mechanism which > > allows a capability check to be skipped doesn't mean I want to allow a > > LSM hook to be used to skip a capability check. > > This work is an attempt to tighten the security of production systems > by allowing to drop too coarse-grained and permissive capabilities > (like CAP_BPF, CAP_PERFMON, CAP_NET_ADMIN, which inevitable allow more > than production use cases are meant to be able to do) and then grant > specific BPF operations on specific BPF programs/maps based on custom > LSM security policy, which validates application trustworthiness using > custom production-specific logic. There are ways to leverage the LSMs to apply finer grained access control on top of the relatively coarse capabilities that do not require circumventing those capability controls. One grants the capabilities, just as one would do today, and then leverages the security functionality of a LSM to further restrict specific users, applications, etc. with a level of granularity beyond that offered by the capability controls. -- paul-moore.com
