> > > >> > >> Also, it seems better to split the xdp_linearize_page() to two functions > >> as pskb_expand_head() and __skb_linearize() do, one to expand the headroom, > >> the other one to do the linearizing. > > > > No skb here. > > I means following the semantics of pskb_expand_head() and __skb_linearize(), > not to combine the headroom expanding and linearizing into one function as > xdp_linearize_page() does now if we want a better refoctor result. Not sure it's worth it, since the use is very specific unless we could find a case that wants only one of them. Thanks > > > > > > >> >