On Thu, 23 Mar 2023 12:45:41 +0800 Yunsheng Lin wrote: > >> Also, it seems better to split the xdp_linearize_page() to two functions > >> as pskb_expand_head() and __skb_linearize() do, one to expand the headroom, > >> the other one to do the linearizing. > > > > No skb here. > > I means following the semantics of pskb_expand_head() and __skb_linearize(), > not to combine the headroom expanding and linearizing into one function as > xdp_linearize_page() does now if we want a better refoctor result. It's a driver-local function, if I was reading the code and saw xdp_prepare_mergeable() I'd have thought it's a function from XDP core. If anything the functions are missing local driver prefix. But it's not a huge deal (given Michael's ping yesterday asking us if we can expedite merging..)
