On Wed, Mar 8, 2023 at 6:30 AM kernel test robot <lkp@xxxxxxxxx> wrote: > > Hi Andrii, > > I love your patch! Yet something to improve: > > [auto build test ERROR on bpf-next/master] > > url: https://github.com/intel-lab-lkp/linux/commits/Andrii-Nakryiko/bpf-factor-out-fetching-basic-kfunc-metadata/20230308-115539 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > patch link: https://lore.kernel.org/r/20230308035416.2591326-5-andrii%40kernel.org > patch subject: [PATCH v4 bpf-next 4/8] bpf: implement number iterator > config: nios2-randconfig-r001-20230306 (https://download.01.org/0day-ci/archive/20230308/202303082250.AUFm2qRJ-lkp@xxxxxxxxx/config) > compiler: nios2-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/19acf9ca01e2927a29d3235b3aa73598430dcb70 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Andrii-Nakryiko/bpf-factor-out-fetching-basic-kfunc-metadata/20230308-115539 > git checkout 19acf9ca01e2927a29d3235b3aa73598430dcb70 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash kernel/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Link: https://lore.kernel.org/oe-kbuild-all/202303082250.AUFm2qRJ-lkp@xxxxxxxxx/ > > All errors (new ones prefixed by >>): > > In file included from <command-line>: > kernel/bpf/bpf_iter.c: In function 'bpf_iter_num_new': > >> include/linux/compiler_types.h:399:45: error: call to '__compiletime_assert_426' declared with attribute error: BUILD_BUG_ON failed: __alignof__(struct bpf_iter_num_kern) != __alignof__(struct bpf_iter_num) > 399 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > | ^ > include/linux/compiler_types.h:380:25: note: in definition of macro '__compiletime_assert' > 380 | prefix ## suffix(); \ > | ^~~~~~ > include/linux/compiler_types.h:399:9: note: in expansion of macro '_compiletime_assert' > 399 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > | ^~~~~~~~~~~~~~~~~~~ > include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' > 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) > | ^~~~~~~~~~~~~~~~~~ > include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' > 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) > | ^~~~~~~~~~~~~~~~ > kernel/bpf/bpf_iter.c:794:9: note: in expansion of macro 'BUILD_BUG_ON' > 794 | BUILD_BUG_ON(__alignof__(struct bpf_iter_num_kern) != __alignof__(struct bpf_iter_num)); > | ^~~~~~~~~~~~ > Well, of course, u64 is not 8-byte aligned on 32-bit architecture, thanks. I'll do the following change in the next revision: diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index bf8b77d9a17e..4abddb668a10 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -7118,6 +7118,6 @@ struct bpf_iter_num { * alignment requirements in vmlinux.h, generated from BTF */ __u64 __opaque[1]; -}; +} __attribute__((aligned(8))); #endif /* _UAPI__LINUX_BPF_H__ */ diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index bf8b77d9a17e..4abddb668a10 100644 --- a/tools/include/uapi/linux/bpf.h +++ b/tools/include/uapi/linux/bpf.h @@ -7118,6 +7118,6 @@ struct bpf_iter_num { * alignment requirements in vmlinux.h, generated from BTF */ __u64 __opaque[1]; -}; +} __attribute__((aligned(8))); > > vim +/__compiletime_assert_426 +399 include/linux/compiler_types.h > > eb5c2d4b45e3d2 Will Deacon 2020-07-21 385 > eb5c2d4b45e3d2 Will Deacon 2020-07-21 386 #define _compiletime_assert(condition, msg, prefix, suffix) \ > eb5c2d4b45e3d2 Will Deacon 2020-07-21 387 __compiletime_assert(condition, msg, prefix, suffix) > eb5c2d4b45e3d2 Will Deacon 2020-07-21 388 > eb5c2d4b45e3d2 Will Deacon 2020-07-21 389 /** > eb5c2d4b45e3d2 Will Deacon 2020-07-21 390 * compiletime_assert - break build and emit msg if condition is false > eb5c2d4b45e3d2 Will Deacon 2020-07-21 391 * @condition: a compile-time constant condition to check > eb5c2d4b45e3d2 Will Deacon 2020-07-21 392 * @msg: a message to emit if condition is false > eb5c2d4b45e3d2 Will Deacon 2020-07-21 393 * > eb5c2d4b45e3d2 Will Deacon 2020-07-21 394 * In tradition of POSIX assert, this macro will break the build if the > eb5c2d4b45e3d2 Will Deacon 2020-07-21 395 * supplied condition is *false*, emitting the supplied error message if the > eb5c2d4b45e3d2 Will Deacon 2020-07-21 396 * compiler has support to do so. > eb5c2d4b45e3d2 Will Deacon 2020-07-21 397 */ > eb5c2d4b45e3d2 Will Deacon 2020-07-21 398 #define compiletime_assert(condition, msg) \ > eb5c2d4b45e3d2 Will Deacon 2020-07-21 @399 _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > eb5c2d4b45e3d2 Will Deacon 2020-07-21 400 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests
