On Tue, Feb 7, 2023 at 4:35 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Tue, 7 Feb 2023 16:21:49 +0100 > Florent Revest <revest@xxxxxxxxxxxx> wrote: > > > Actually, I'm not sure anymore if we should delete the !multi samples... > > > > I realized that they are also used as part of the ftrace selftests in: > > - tools/testing/selftests/ftrace/test.d/direct/ftrace-direct.tc > > - tools/testing/selftests/ftrace/test.d/direct/kprobe-direct.tc > > > > It does not really make sense to use the ftrace-direct-muti sample as > > a drop-in replacement for the ftrace-direct sample there since they > > don't really do the same thing so we would either need to change the > > test a bit or the multi sample. > > Also, we would still need to adapt the ftrace-direct-too sample since > > it has no multi equivalent and is required there. > > Let's not delete the samples, and they do test slightly different use cases > (although the code may be somewhat the same). I rather still keep that test > coverage. > > -- Steve Ack :) Thanks Steve! I'll undo the work I've started to do on this and send a v2 shortly afterward.
