On Thu, Feb 2, 2023 at 4:02 PM Mark Rutland <mark.rutland@xxxxxxx> wrote: > Looking at samples/ftrace/, as of this patch we have a few samples that are > almost identical, modulo the function being traced, and some different register > shuffling for arguments: > > * ftrace-direct.c and ftrace-direct-multi.c > * ftrace-direct-modify.c and ftrace-direct-modify > > ... perhaps it would be better to just delete the !multi versions ? The multi versions hook two functions and the !multi hook just one but I agree that this granularity in coverage is probably just a maintenance burden and doesn't help with much! :) I'll delete the !multi in v2, as part of the patch 2 and patch 1 will just migrate the selftest to use the multi API.
