On Wed, Jan 25, 2023 at 08:41:00AM +0100, Jiri Olsa wrote: > On Tue, Jan 24, 2023 at 07:49:38PM -0800, Alexei Starovoitov wrote: > > On Tue, Jan 24, 2023 at 6:36 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > > > > > hi, > > > I noticed several times in discussions that we should move test kfuncs > > > into kernel module, now perhaps even more pressing with all the kfunc > > > effort. This patchset moves all the test kfuncs into bpf_testmod. > > > > > > I added bpf_testmod/bpf_testmod_kfunc.h header that is shared between > > > bpf_testmod kernel module and BPF programs, which brings some difficulties > > > with __ksym define. But I'm not sure having separate headers for BPF > > > programs and for kernel module would be better. > > > > This part looks fine and overall it's great. > > Thanks a lot for working on this. > > But see failing tests. > > test_progs-no_alu32 -t cb_refs > > oops, forgot about alu32 :-\ will check it seems to be related to missing commit in bpf-next/master: 74bc3a5acc82 bpf: Add missing btf_put to register_btf_id_dtor_kfuncs it's in bpf/master now and I have it on my branch, when I revert it I see same errors as in CI I can include it in next post or wait for bpf-next to catch up with bpf jirka
