On Tue, Jan 24, 2023 at 07:49:38PM -0800, Alexei Starovoitov wrote: > On Tue, Jan 24, 2023 at 6:36 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote: > > > > hi, > > I noticed several times in discussions that we should move test kfuncs > > into kernel module, now perhaps even more pressing with all the kfunc > > effort. This patchset moves all the test kfuncs into bpf_testmod. > > > > I added bpf_testmod/bpf_testmod_kfunc.h header that is shared between > > bpf_testmod kernel module and BPF programs, which brings some difficulties > > with __ksym define. But I'm not sure having separate headers for BPF > > programs and for kernel module would be better. > > This part looks fine and overall it's great. > Thanks a lot for working on this. > But see failing tests. > test_progs-no_alu32 -t cb_refs oops, forgot about alu32 :-\ will check jirka > is consistently failing. > Also it seems it introduces instability into other tests. > BPF CI isn't happy.
