Re: [PATCHv4 bpf-next 2/4] bpf: Add bpf_vma_build_id_parse function and kfunc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 29, 2022 at 4:35 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
> This is hardly a generic solution, as it requires instrumenting every
> application to do this, right? So what I'm proposing is exactly to
> avoid having each individual application do something special just to
> allow profiling tools to capture build_id.

I agree. Because the mlock approach is working, we didn't look further
or try improving it. But an upstreamable and generic solution would be
nice. I think Jiri has started looking at it, I am happy to help
there.

> Is this due to remapping some binary onto huge pages?

I think so, but I'm not sure.

> But regardless, your custom BPF applications can fetch this build_id
> from vm_area_struct->anon_name in pure BPF code, can't it? Why do you
> need to modify in-kernel build_id_parse implementation?

The user is using bpf_get_stack() to collect stack traces. They don't
implement walking the stack and fetching build_id from vma in their
BPF code.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux