On 10/18/22 11:00 AM, Jakub Kicinski wrote:
On Tue, 18 Oct 2022 17:50:19 +0800 wangyufen wrote:
So, there are two possible approaches: the first moving nat6to4.c and
the actual test programs to selftests/bpf;
second add make dependency on libbpf for the nat6to4.c.
Which one is better?
Can we move the programs and create a dependency from them back
to networking? Perhaps shared components like udpgso_* need to live
under tools/net so they can be easily "depended on"?
Either that or they need to switch to a different traffic generator for
the BPF test, cause there's more networking selftests using the UDP
generators :(
All (at least most) of the selftests/bpf/test_prog's tests generate its own
traffic for unit test purpose such that each test is self contained. The
udpgro_frglist test should do the same in selftests/bpf/test_prog (meaning the
test itself should generate its own testing traffic). Also, it does not look
like it is actually using udpgso_bench_* to do benchmarking.
