On 9/2/22 4:52 PM, YiFei Zhu wrote:
btw, does it make sense to do it as a subtest in
connect_force_port.c or they are very different?
I could try, but they are structured differently; that checks the
ports whereas this checks the bound IPs. That test also doesn't use
skels or sets up netns whereas this test does. I think I would prefer
to have two tests since tests are cheap, but I can try to restructure
connect_force_port.c in a way that is compatible with both if you
insist.
Yep. Keeping them separate is fine. I was asking because they are
testing the same hook other than the port-vs-ip difference.
connect[46]_prog.c looks like a better one also but not yet in
test_progs infra. It will be useful to migrate it in the future.
