[PATCH bpf] bpf, docs: Better scale maintenance of BPF subsystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Alexei Starovoitov <ast@xxxxxxxxxx>

The BPF subsystem consists of a large number of pieces. There is not a
single person that understands it all. Yet reviews are crucially important
for the BPF community to provide productive quality feedback to contributors
in a timely manner and therefore to ultimately expand the number of active
developers in the community.

So far, the BPF community had a two-stage review system, that is, a weekly
rotation among 7 developers (Alexei, Daniel, Andrii, Martin, Song, Yonghong,
John) as a first-level review of all inbound patches accompanied by a BPF CI
system which runs the in-tree BPF selftests to check for regressions for
every new patch, and then, a final check by Alexei, Daniel, Andrii to apply
the patches to either bpf or bpf-next trees.

This system worked well for the last ~3.5 years, but clearly reaches its
limits these days as it does not scale enough. Especially, as we also need
to allow enough room for every developer to contribute patches themselves,
integrate with their day to day job, and in particular avoid burnout. We
want to better scale both horizontally and vertically going forward.

On the horizontal scale, we are adding more developers (KP, Stan, Hao, Jiri)
to the overall core reviewer team, thus growing to 11 people in total. The
weekly rotation for the horizontal oncall reviewer is shortened to 1/2 week
(Mo - Wed and Thur - Fri). Instead of just patches, the coverage however
extends also generally to triage and reply to mailing list traffic (e.g. RFCs,
questions, etc).

On the vertical scale, there is clearly a need for deep expertise areas to
assign dedicated maintainer/reviewer teams that are responsible for code
reviews and help with design of individual building blocks. To some degree
we have been doing this implicitly, but the point is to formalize the teams
and commitment.

There is an overlap between areas and boundaries are intentionally grey. These
additional entries provide a guidance on who has to look at the patches. The
patch series which span multiple areas will be looked at by multiple people.
The vertical review with areas of deep expertise are bundled at the same time
with the horizontal side.

This patch cleans up a bit the BPF entries, adds mentioned developers to
the horizontal scale and creates new sub-entries with teams for developers
committing to the above outlined vertical scale.

Signed-off-by: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
Acked-by: Martin KaFai Lau <martin.lau@xxxxxxxxx>
Acked-by: Song Liu <song@xxxxxxxxxx>
Acked-by: Yonghong Song <yhs@xxxxxx>
Acked-by: Mykola Lysenko <mykolal@xxxxxx>
Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>
Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Acked-by: KP Singh <kpsingh@xxxxxxxxxx>
Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
Acked-by: Hao Luo <haoluo@xxxxxxxxxx>
Acked-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>
---
 MAINTAINERS | 108 +++++++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 90 insertions(+), 18 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 15a2341936ea..dbf978014e8a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3614,16 +3614,18 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/iio/accel/bosch,bma400.yaml
 F:	drivers/iio/accel/bma400*
 
-BPF (Safe dynamic programs and tools)
+BPF [GENERAL] (Safe Dynamic Programs and Tools)
 M:	Alexei Starovoitov <ast@xxxxxxxxxx>
 M:	Daniel Borkmann <daniel@xxxxxxxxxxxxx>
 M:	Andrii Nakryiko <andrii@xxxxxxxxxx>
-R:	Martin KaFai Lau <kafai@xxxxxx>
-R:	Song Liu <songliubraving@xxxxxx>
+R:	Martin KaFai Lau <martin.lau@xxxxxxxxx>
+R:	Song Liu <song@xxxxxxxxxx>
 R:	Yonghong Song <yhs@xxxxxx>
 R:	John Fastabend <john.fastabend@xxxxxxxxx>
 R:	KP Singh <kpsingh@xxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
+R:	Stanislav Fomichev <sdf@xxxxxxxxxx>
+R:	Hao Luo <haoluo@xxxxxxxxxx>
+R:	Jiri Olsa <jolsa@xxxxxxxxxx>
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Supported
 W:	https://bpf.io/
@@ -3660,7 +3662,6 @@ K:	bpf
 
 BPF JIT for ARM
 M:	Shubham Bansal <illusionist.neo@xxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Odd Fixes
 F:	arch/arm/net/
@@ -3669,7 +3670,6 @@ BPF JIT for ARM64
 M:	Daniel Borkmann <daniel@xxxxxxxxxxxxx>
 M:	Alexei Starovoitov <ast@xxxxxxxxxx>
 M:	Zi Shen Lim <zlim.lnx@xxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Supported
 F:	arch/arm64/net/
@@ -3677,14 +3677,12 @@ F:	arch/arm64/net/
 BPF JIT for MIPS (32-BIT AND 64-BIT)
 M:	Johan Almbladh <johan.almbladh@xxxxxxxxxxxxxxxxx>
 M:	Paul Burton <paulburton@xxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Maintained
 F:	arch/mips/net/
 
 BPF JIT for NFP NICs
 M:	Jakub Kicinski <kuba@xxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Odd Fixes
 F:	drivers/net/ethernet/netronome/nfp/bpf/
@@ -3692,7 +3690,6 @@ F:	drivers/net/ethernet/netronome/nfp/bpf/
 BPF JIT for POWERPC (32-BIT AND 64-BIT)
 M:	Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxx>
 M:	Michael Ellerman <mpe@xxxxxxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Supported
 F:	arch/powerpc/net/
@@ -3700,7 +3697,6 @@ F:	arch/powerpc/net/
 BPF JIT for RISC-V (32-bit)
 M:	Luke Nelson <luke.r.nels@xxxxxxxxx>
 M:	Xi Wang <xi.wang@xxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Maintained
 F:	arch/riscv/net/
@@ -3708,7 +3704,6 @@ X:	arch/riscv/net/bpf_jit_comp64.c
 
 BPF JIT for RISC-V (64-bit)
 M:	Björn Töpel <bjorn@xxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Maintained
 F:	arch/riscv/net/
@@ -3718,7 +3713,6 @@ BPF JIT for S390
 M:	Ilya Leoshkevich <iii@xxxxxxxxxxxxx>
 M:	Heiko Carstens <hca@xxxxxxxxxxxxx>
 M:	Vasily Gorbik <gor@xxxxxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Supported
 F:	arch/s390/net/
@@ -3726,14 +3720,12 @@ X:	arch/s390/net/pnet.c
 
 BPF JIT for SPARC (32-BIT AND 64-BIT)
 M:	David S. Miller <davem@xxxxxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Odd Fixes
 F:	arch/sparc/net/
 
 BPF JIT for X86 32-BIT
 M:	Wang YanQing <udknight@xxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Odd Fixes
 F:	arch/x86/net/bpf_jit_comp32.c
@@ -3741,13 +3733,60 @@ F:	arch/x86/net/bpf_jit_comp32.c
 BPF JIT for X86 64-BIT
 M:	Alexei Starovoitov <ast@xxxxxxxxxx>
 M:	Daniel Borkmann <daniel@xxxxxxxxxxxxx>
-L:	netdev@xxxxxxxxxxxxxxx
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Supported
 F:	arch/x86/net/
 X:	arch/x86/net/bpf_jit_comp32.c
 
-BPF LSM (Security Audit and Enforcement using BPF)
+BPF [CORE]
+M:	Alexei Starovoitov <ast@xxxxxxxxxx>
+M:	Daniel Borkmann <daniel@xxxxxxxxxxxxx>
+R:	John Fastabend <john.fastabend@xxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	kernel/bpf/verifier.c
+F:	kernel/bpf/tnum.c
+F:	kernel/bpf/core.c
+F:	kernel/bpf/syscall.c
+F:	kernel/bpf/dispatcher.c
+F:	kernel/bpf/trampoline.c
+F:	include/linux/bpf*
+F:	include/linux/filter.h
+
+BPF [BTF]
+M:	Martin KaFai Lau <martin.lau@xxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	kernel/bpf/btf.c
+F:	include/linux/btf*
+
+BPF [TRACING]
+M:	Song Liu <song@xxxxxxxxxx>
+R:	Jiri Olsa <jolsa@xxxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	kernel/trace/bpf_trace.c
+F:	kernel/bpf/stackmap.c
+
+BPF [NETWORKING] (tc BPF, sock_addr)
+M:	Martin KaFai Lau <martin.lau@xxxxxxxxx>
+M:	Daniel Borkmann <daniel@xxxxxxxxxxxxx>
+R:	John Fastabend <john.fastabend@xxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+L:	netdev@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	net/core/filter.c
+F:	net/sched/act_bpf.c
+F:	net/sched/cls_bpf.c
+
+BPF [NETWORKING] (struct_ops, reuseport)
+M:	Martin KaFai Lau <martin.lau@xxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+L:	netdev@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	kernel/bpf/bpf_struct*
+
+BPF [SECURITY & LSM] (Security Audit and Enforcement using BPF)
 M:	KP Singh <kpsingh@xxxxxxxxxx>
 R:	Florent Revest <revest@xxxxxxxxxxxx>
 R:	Brendan Jackman <jackmanb@xxxxxxxxxxxx>
@@ -3758,7 +3797,27 @@ F:	include/linux/bpf_lsm.h
 F:	kernel/bpf/bpf_lsm.c
 F:	security/bpf/
 
-BPF L7 FRAMEWORK
+BPF [STORAGE & CGROUPS]
+M:	Martin KaFai Lau <martin.lau@xxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	kernel/bpf/cgroup.c
+F:	kernel/bpf/*storage.c
+F:	kernel/bpf/bpf_lru*
+
+BPF [RINGBUF]
+M:	Andrii Nakryiko <andrii@xxxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	kernel/bpf/ringbuf.c
+
+BPF [ITERATOR]
+M:	Yonghong Song <yhs@xxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	kernel/bpf/*iter.c
+
+BPF [L7 FRAMEWORK] (sockmap)
 M:	John Fastabend <john.fastabend@xxxxxxxxx>
 M:	Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
 L:	netdev@xxxxxxxxxxxxxxx
@@ -3771,13 +3830,26 @@ F:	net/ipv4/tcp_bpf.c
 F:	net/ipv4/udp_bpf.c
 F:	net/unix/unix_bpf.c
 
-BPFTOOL
+BPF [LIBRARY] (libbpf)
+M:	Andrii Nakryiko <andrii@xxxxxxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	tools/lib/bpf/
+
+BPF [TOOLING] (bpftool)
 M:	Quentin Monnet <quentin@xxxxxxxxxxxxx>
 L:	bpf@xxxxxxxxxxxxxxx
 S:	Maintained
 F:	kernel/bpf/disasm.*
 F:	tools/bpf/bpftool/
 
+BPF [SELFTESTS] (Test Runners & Infrastructure)
+M:	Andrii Nakryiko <andrii@xxxxxxxxxx>
+R:	Mykola Lysenko <mykolal@xxxxxx>
+L:	bpf@xxxxxxxxxxxxxxx
+S:	Maintained
+F:	tools/testing/selftests/bpf/
+
 BROADCOM B44 10/100 ETHERNET DRIVER
 M:	Michael Chan <michael.chan@xxxxxxxxxxxx>
 L:	netdev@xxxxxxxxxxxxxxx
-- 
2.21.0




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux