This patch series allows for using bpf to collect hierarchical cgroup stats efficiently by integrating with the rstat framework. The rstat framework provides an efficient way to collect cgroup stats and propagate them through the cgroup hierarchy. * Background on rstat (I am using a subscriber analogy that is not commonly used): The rstat framework maintains a tree of cgroups that have updates and which cpus have updates. A subscriber to the rstat framework maintains their own stats. The framework is used to tell the subscriber when and what to flush, for the most efficient stats propagation. The workflow is as follows: - When a subscriber updates a cgroup on a cpu, it informs the rstat framework by calling cgroup_rstat_updated(cgrp, cpu). - When a subscriber wants to read some stats for a cgroup, it asks the rstat framework to initiate a stats flush (propagation) by calling cgroup_rstat_flush(cgrp). - When the rstat framework initiates a flush, it makes callbacks to subscribers to aggregate stats on cpus that have updates, and propagate updates to their parent. Currently, the main subscribers to the rstat framework are cgroup subsystems (e.g. memory, block). This patch series allow bpf programs to become subscribers as well. The first three patches introduce a new bpf program type, RSTAT_FLUSH, which is a callback that rstat makes to bpf when a stats flush is ongoing. The fourth patch adds bpf_cgroup_rstat_updated() and bpf_cgroup_rstat_flush() helpers, to allow bpf stat collectors and readers to communicate with rstat. The fifth patch is actually v2 of a previously submitted patch [1] by Hao Luo. We agreed that it fits better as a part of this series. It introduces cgroup_iter programs that can dump stats for cgroups to userspace. v1 - > v2: - Getting the cgroup's reference at the time at attaching, instead of at the time when iterating. (Yonghong) (context [1]) - Remove .init_seq_private and .fini_seq_private callbacks for cgroup_iter. They are not needed now. (Yonghong) The sixth patch extends bpf selftests cgroup helpers, as necessary for the following patch. The seventh patch is a selftest that demonstrates the entire workflow. It includes programs that collect, aggregate, and dump per-cgroup stats by fully integrating with the rstat framework. [1]https://lore.kernel.org/lkml/20220225234339.2386398-9-haoluo@xxxxxxxxxx/ RFC v1 -> RFC v2: - Instead of rstat flush programs attach to subsystems, they now attach to rstat (global flushers, not per-subsystem), based on discussions with Tejun. The first patch is entirely rewritten. - Pass cgroup pointers to rstat flushers instead of cgroup ids. This is much more flexibility and less likely to need a uapi update later. - rstat helpers are now only defined if CGROUP_CONFIG. - Most of the code is now only defined if CGROUP_CONFIG and CONFIG_BPF_SYSCALL. - Move rstat helper protos from bpf_base_func_proto() to tracing_prog_func_proto(). - rstat helpers argument (cgroup pointer) is now ARG_PTR_TO_BTF_ID, not ARG_ANYTHING. - Rewrote the selftest to use the cgroup helpers. - Dropped bpf_map_lookup_percpu_elem (already added by Feng). - Dropped patch to support cgroup v1 for cgroup_iter. - Dropped patch to define some cgroup_put() when !CONFIG_CGROUP. The code that calls it is no longer compiled when !CONFIG_CGROUP. Hao Luo (1): bpf: Introduce cgroup iter Yosry Ahmed (6): bpf: introduce RSTAT_FLUSH program type cgroup: bpf: flush bpf stats on rstat flush libbpf: Add support for rstat flush progs bpf: add bpf rstat helpers selftests/bpf: extend cgroup helpers bpf: add a selftest for cgroup hierarchical stats collection include/linux/bpf-rstat.h | 31 ++ include/linux/bpf.h | 4 + include/linux/bpf_types.h | 4 + include/uapi/linux/bpf.h | 33 ++ kernel/bpf/Makefile | 3 + kernel/bpf/cgroup_iter.c | 148 ++++++++ kernel/bpf/helpers.c | 30 ++ kernel/bpf/rstat.c | 187 ++++++++++ kernel/bpf/syscall.c | 6 + kernel/cgroup/rstat.c | 2 + kernel/trace/bpf_trace.c | 4 + scripts/bpf_doc.py | 2 + tools/include/uapi/linux/bpf.h | 33 ++ tools/lib/bpf/bpf.c | 1 - tools/lib/bpf/libbpf.c | 40 +++ tools/lib/bpf/libbpf.h | 3 + tools/lib/bpf/libbpf.map | 1 + tools/testing/selftests/bpf/cgroup_helpers.c | 158 +++++--- tools/testing/selftests/bpf/cgroup_helpers.h | 14 +- .../test_cgroup_hierarchical_stats.c | 339 ++++++++++++++++++ tools/testing/selftests/bpf/progs/bpf_iter.h | 7 + .../selftests/bpf/progs/cgroup_vmscan.c | 222 ++++++++++++ 22 files changed, 1225 insertions(+), 47 deletions(-) create mode 100644 include/linux/bpf-rstat.h create mode 100644 kernel/bpf/cgroup_iter.c create mode 100644 kernel/bpf/rstat.c create mode 100644 tools/testing/selftests/bpf/prog_tests/test_cgroup_hierarchical_stats.c create mode 100644 tools/testing/selftests/bpf/progs/cgroup_vmscan.c -- 2.36.0.550.gb090851708-goog
