On Fri, Apr 8, 2022 at 3:53 PM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote: > > Common code to initialize a struct usdt_arg_spec can be factored out > from arch-specific flavours of parse_usdt_arg(); signed size, > bitshift handling etc. > > Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx> > --- I understand that there is a bit of repetition between multiple architectures, but I think this init_usdt_arg_spec() helper is actually hindering understand. Can you please drop this refactoring for now? It's just a few lines of code that you'll need to copy/paste for argument bit shift handling, not a big deal, right? > tools/lib/bpf/usdt.c | 90 ++++++++++++++++++++++++---------------------------- > 1 file changed, 41 insertions(+), 49 deletions(-) > [...]
