I think we have reached a consensus [1] on how the test for the 4-byte load from
bpf_sock->dst_port and bpf_sk_lookup->remote_port should look, so here goes v3.
I will submit a separate set of patches for bpf_sk_lookup->remote_port tests.
This series has been tested on x86_64 and s390 on top of recent bpf-next -
ad13baf45691 ("selftests/bpf: Test subprog jit when toggle bpf_jit_harden
repeatedly").
[1] https://lore.kernel.org/bpf/87k0cwxkzs.fsf@xxxxxxxxxxxxxx/
v2 -> v3:
- Split what was previously patch 2 which was doing two things
- Use BPF_TCP_* constants (Martin)
- Treat the result of 4-byte load from dst_port as a 16-bit value (Martin)
- Typo fixup and some rewording in patch 4 description
v1 -> v2:
- Limit read_sk_dst_port only to client traffic (patch 2)
- Make read_sk_dst_port pass on litte- and big-endian (patch 3)
v1: https://lore.kernel.org/bpf/20220225184130.483208-1-jakub@xxxxxxxxxxxxxx/
v2: https://lore.kernel.org/bpf/20220227202757.519015-1-jakub@xxxxxxxxxxxxxx/
Jakub Sitnicki (4):
selftests/bpf: Fix error reporting from sock_fields programs
selftests/bpf: Check dst_port only on the client socket
selftests/bpf: Use constants for socket states in sock_fields test
selftests/bpf: Fix test for 4-byte load from dst_port on big-endian
.../selftests/bpf/progs/test_sock_fields.c | 24 +++++++++++++------
1 file changed, 17 insertions(+), 7 deletions(-)
--
2.35.1
