On Thu, Mar 03, 2022 at 04:15:06AM IST, Alexei Starovoitov wrote: > On Mon, Feb 28, 2022 at 10:58 PM Kumar Kartikeya Dwivedi > <memxor@xxxxxxxxx> wrote: > > > > Verifier for negative offset case returns a different, more clear error > > message. Update existing verifier selftests to work with that. > > > > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx> > > --- > > tools/testing/selftests/bpf/verifier/bounds_deduction.c | 2 +- > > tools/testing/selftests/bpf/verifier/ctx.c | 8 ++++---- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/tools/testing/selftests/bpf/verifier/bounds_deduction.c b/tools/testing/selftests/bpf/verifier/bounds_deduction.c > > index 91869aea6d64..3931c481e30c 100644 > > --- a/tools/testing/selftests/bpf/verifier/bounds_deduction.c > > +++ b/tools/testing/selftests/bpf/verifier/bounds_deduction.c > > @@ -105,7 +105,7 @@ > > BPF_EXIT_INSN(), > > }, > > .errstr_unpriv = "R1 has pointer with unsupported alu operation", > > - .errstr = "dereference of modified ctx ptr", > > + .errstr = "negative offset ctx ptr R1 off=-1 disallowed", > > Should this be a part of patch 3 to avoid breaking bisect? Right, will squash into patch 3 in v2. -- Kartikeya
