Re: [PATCH v4 2/3] libbpf: Fix the incorrect register read for syscalls on x86_64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 20, 2022 at 2:57 PM <Kenta.Tada@xxxxxxxx> wrote:
>
> >did you check PT_REGS_PARM4_CORE() definition? This should be
>
> In my local test, this wrong code can pass the correct arg4 because the test just checks the value.

The biggest problem is the lack of bpf_probe_read_kernel(). Your
definition does direct memory read which won't work if pt_regs is not
an input context to the BPF program. Which is exactly the case for
syscalls.

> Anyway I should attach the test for CORE variants at first.
> Sorry. I'll fix the issues and add tests for CORE variants this weekend.



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux